[refactor][broker] Use AuthenticationParameters for rest producer #20046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
area/admin
doc-not-needed
Codecov Report
@@ Coverage Diff @@
## master #20046 +/- ##
=========================================
Coverage 72.86% 72.86%
- Complexity 31628 31643 +15
=========================================
Files 1861 1858 -3
Lines 137500 137434 -66
Branches 15141 15106 -35
=========================================
- Hits 100187 100143 -44
+ Misses 29351 29312 -39
- Partials 7962 7979 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattisonchao
approved these changes
Apr 10, 2023
michaeljmarshall
added a commit
that referenced
this pull request
Apr 10, 2023
…0046) In #19975, we introduced a wrapper for all authentication parameters. This PR adds that wrapper to the Rest Producer. * Use `AuthenticationParameters` to simplify parameter management in Rest Producer. * Add method to the `AuthorizationService` that takes the `AuthenticationParameters`. * Update annotations on Rest Producer to indicate that a 401 is an expected response. This change is covered by the `TopicsAuthTest`. - [x] `doc-not-needed` This is an internal change that does not need to be documented. PR in forked repository: skipping PR since the relevant tests pass locally (cherry picked from commit 7990948)
michaeljmarshall
added a commit
that referenced
this pull request
Apr 10, 2023
…0046) In #19975, we introduced a wrapper for all authentication parameters. This PR adds that wrapper to the Rest Producer. * Use `AuthenticationParameters` to simplify parameter management in Rest Producer. * Add method to the `AuthorizationService` that takes the `AuthenticationParameters`. * Update annotations on Rest Producer to indicate that a 401 is an expected response. This change is covered by the `TopicsAuthTest`. - [x] `doc-not-needed` This is an internal change that does not need to be documented. PR in forked repository: skipping PR since the relevant tests pass locally (cherry picked from commit 7990948) (cherry picked from commit 02b27e8)
michaeljmarshall
added a commit
that referenced
this pull request
Apr 10, 2023
…0046) In #19975, we introduced a wrapper for all authentication parameters. This PR adds that wrapper to the Rest Producer. * Use `AuthenticationParameters` to simplify parameter management in Rest Producer. * Add method to the `AuthorizationService` that takes the `AuthenticationParameters`. * Update annotations on Rest Producer to indicate that a 401 is an expected response. This change is covered by the `TopicsAuthTest`. - [x] `doc-not-needed` This is an internal change that does not need to be documented. PR in forked repository: skipping PR since the relevant tests pass locally (cherry picked from commit 7990948) (cherry picked from commit 02b27e8)
michaeljmarshall
added
cherry-picked/branch-2.9
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Apr 11, 2023
…ache#20046) ### Motivation In apache#19975, we introduced a wrapper for all authentication parameters. This PR adds that wrapper to the Rest Producer. ### Modifications * Use `AuthenticationParameters` to simplify parameter management in Rest Producer. * Add method to the `AuthorizationService` that takes the `AuthenticationParameters`. * Update annotations on Rest Producer to indicate that a 401 is an expected response. ### Verifying this change This change is covered by the `TopicsAuthTest`. ### Documentation - [x] `doc-not-needed` This is an internal change that does not need to be documented. ### Matching PR in forked repository PR in forked repository: skipping PR since the relevant tests pass locally
michaeljmarshall
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 11, 2023
…ache#20046) In apache#19975, we introduced a wrapper for all authentication parameters. This PR adds that wrapper to the Rest Producer. * Use `AuthenticationParameters` to simplify parameter management in Rest Producer. * Add method to the `AuthorizationService` that takes the `AuthenticationParameters`. * Update annotations on Rest Producer to indicate that a 401 is an expected response. This change is covered by the `TopicsAuthTest`. - [x] `doc-not-needed` This is an internal change that does not need to be documented. PR in forked repository: skipping PR since the relevant tests pass locally (cherry picked from commit 7990948) (cherry picked from commit 02b27e8)
Member
Author
|
As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #19975, we introduced a wrapper for all authentication parameters. This PR adds that wrapper to the Rest Producer.
Modifications
AuthenticationParametersto simplify parameter management in Rest Producer.AuthorizationServicethat takes theAuthenticationParameters.Verifying this change
This change is covered by the
TopicsAuthTest.Documentation
doc-not-neededThis is an internal change that does not need to be documented.
Matching PR in forked repository
PR in forked repository: skipping PR since the relevant tests pass locally