[fix][client] Move MessageIdAdv to the pulsar-common module

[BewareMyPower]

Motivation

#19414 does not follow the design of #18950

Since the aimed developers are Pulsar core developers, it's added in
the pulsar-common module (PulsarApi.proto is also in this module), not
the pulsar-client-api module.

The reason to made such changes in the previous PR was that TopicMessageId#create now cannot be a MessageIdAdv if MessageIdAdv is not in the pulsar-client-api module. However, it can be avoided.

Modifications

• Move the MessageIdAdv class to the pulsar-common module.
• Implement the MessageIdAdv interface in TopicMessageIdImpl instead of TopicMessageId.Impl.
• Create a TopicMessageIdImpl instance for TopicMessageId#create via the DefaultImplementation class with the overhead of reflection.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: BewareMyPower#27

[cbornet]

We are in code freeze for 3.0.
Since this is affecting the public API, I guess we want to have it to avoid a breaking change later ?
@BewareMyPower can you confirm or can this be delayed to 3.1 ?

[BewareMyPower]

I guess we want to have it to avoid a breaking change later ?

Yes. It's important to include this change in the 3.0.0 release so I added the 3.0.0 milestone. Otherwise, this change could be a terrible breaking change.

BTW, I have also replied in the 3.0.0 candidate 2 verify mail list: https://lists.apache.org/thread/5bwg9dpcffnzvvgxc9dj1n44otmy81pf

[codecov-commenter]

Codecov Report

❌ Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.95%. Comparing base (9b72302) to head (00c28e0).
⚠️ Report is 2609 commits behind head on master.

Files with missing lines	Patch %	Lines
...nt/impl/PulsarClientImplementationBindingImpl.java	28.57%	4 Missing and 1 partial ⚠️
.../apache/pulsar/client/impl/TopicMessageIdImpl.java	90.00%	2 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #20139       +/-   ##
=============================================
+ Coverage     33.17%   72.95%   +39.77%     
- Complexity    12236    31945    +19709     
=============================================
  Files          1499     1868      +369     
  Lines        114413   138418    +24005     
  Branches      12431    15236     +2805     
=============================================
+ Hits          37962   100977    +63015     
+ Misses        71499    29415    -42084     
- Partials       4952     8026     +3074     

Flag	Coverage Δ
inttests	24.22% <45.45%> (?)
systests	24.75% <45.45%> (?)
unittests	72.25% <78.78%> (+39.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...a/org/apache/pulsar/client/api/TopicMessageId.java	33.33% <100.00%> (-46.67%)	⬇️
...nt/internal/PulsarClientImplementationBinding.java	62.50% <ø> (+12.50%)	⬆️
...va/org/apache/pulsar/client/impl/ConsumerImpl.java	76.83% <100.00%> (+21.65%)	⬆️
...a/org/apache/pulsar/client/impl/MessageIdImpl.java	90.27% <100.00%> (+51.38%)	⬆️
...rg/apache/pulsar/client/impl/TopicMessageImpl.java	65.11% <100.00%> (+25.58%)	⬆️
...ava/org/apache/pulsar/client/api/MessageIdAdv.java	84.21% <ø> (ø)
...a/org/apache/pulsar/websocket/ConsumerHandler.java	67.51% <100.00%> (+67.51%)	⬆️
.../apache/pulsar/client/impl/TopicMessageIdImpl.java	69.23% <90.00%> (+6.73%)	⬆️
...nt/impl/PulsarClientImplementationBindingImpl.java	80.00% <28.57%> (+24.82%)	⬆️

... and 1533 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[BewareMyPower]

I have cherry-picked this PR to branch-3.0. /cc @cbornet @RobertIndie