-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix] [broker] [Branch-2.10] Upgrade rocksDB version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version #20243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Technoboy-
merged 2 commits into
apache:branch-2.10
from
hangc0276:chenhang/upgrade_rocksdb_to_6.29.4.1_for_branch-2.10
May 7, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
May 7, 2023
Member
|
Since the merge of this some of our Pulsar 2.10 integration tests are failing these include errors in Bookkeeper pods like: |
hangc0276
added a commit
to hangc0276/pulsar
that referenced
this pull request
May 10, 2023
… sync with BookKeeper's RocksDB version (apache#20243)" This reverts commit f88a49e.
Contributor
Author
|
Hi @dave2wave, I have pushed one PR #20287 to revert this change. The Pulsar RocksDB version upgrade should be done after the BookKeeper side upgradation. Refer to #14962 (comment) |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cksDB version
Fixes #xyz
Master Issue: #xyz
PIP: #xyz
Motivation
Ugrade the RocksDB's version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: