[feat][broker] introduce precise broker publish rate limiting #20292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@codelipenghui PTAL，thanks! |
Contributor
Author
|
@Jason918 PTAL,thanks! |
Contributor
Author
|
@aloyszhang PTAL,thanks! |
Contributor
|
@lordcheng10 nice patch~ can you add a unit test to simulate this, maybe just check rate is below the setting is enough. |
aloyszhang
reviewed
May 11, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Show resolved
Hide resolved
|
The pr had no activity for 30 days, mark with Stale label. |
Member
|
Rate limiting was revisited in Pulsar 3.2.0 with PIP-322. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The publish rate limit for each broker is ineffective, and the reason for this problem is the same as #7078;
Modifications
When preciseTopicPublishRateLimiterEnable=true, use PrecisPublishLimiter as the publish rate limit for each broker.
A comparative test：
test steps：
1.Start prducer perf, the qps of broker is 10w/s:
2.Enable broker speed limit：
sh bin/pulsar-admin brokers update-dynamic-config --config brokerPublisherThrottlingMaxMessageRate --value 500003.The speed limit effect is as follows: Broker write rate limit does not take effect
4.Use the improved precision speed limit feature：It can be seen that the speed limit effect is as expected
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lordcheng10#49