[fix][io] Close the kafka source connector if there is uncaught exception#20424
Merged
RobertIndie merged 2 commits intoapache:masterfrom May 29, 2023
Merged
[fix][io] Close the kafka source connector if there is uncaught exception#20424RobertIndie merged 2 commits intoapache:masterfrom
RobertIndie merged 2 commits intoapache:masterfrom
Conversation
…ght exception Signed-off-by: Zike Yang <zike@apache.org>
RobertIndie
added
type/bug
RobertIndie
changed the title
…ectedExceptionThrownTest` Signed-off-by: Zike Yang <zike@apache.org>
BewareMyPower
approved these changes
May 29, 2023
tisonkun
approved these changes
May 29, 2023
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20424 +/- ##
=========================================
Coverage 72.90% 72.91%
- Complexity 31864 31896 +32
=========================================
Files 1864 1865 +1
Lines 138416 138443 +27
Branches 15188 15192 +4
=========================================
+ Hits 100919 100945 +26
- Misses 29477 29488 +11
+ Partials 8020 8010 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
|
@liudezhi2098 the label "cherry-picked/*" should be only added after the PR is cherry-picked. If you want to make the PR should be cherry-picked to branch-2.10, you should add "release/2.10.5". |
Contributor
|
@RobertIndie Could you please help cherry-pick this PR to release branches? |
This was referenced Jun 2, 2023
Merged
RobertIndie
added a commit
that referenced
this pull request
Jun 2, 2023
…tion (#20424) Fixes #19880 ### Motivation If any unexpected and uncaught exceptions are thrown in the `runnerThread` of the Kafka source connector, the connector will just log that message and get stuck. The connector won't exit but won't do anything either. ### Modifications * Close the connector if there is uncaught exception Signed-off-by: Zike Yang <zike@apache.org> (cherry picked from commit 6079a91)
Member
Author
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19880
Motivation
If any unexpected and uncaught exceptions are thrown in the
runnerThreadof the Kafka source connector, the connector will just log that message and get stuck. The connector won't exit but won't do anything either.Modifications
Verifying this change
This change added tests
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: