Skip to content

[improve][test] Add unit test for metadata cache #20363 #20436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
poorbarcode merged 1 commit into from
May 30, 2023
Merged

[improve][test] Add unit test for metadata cache #20363 #20436

poorbarcode merged 1 commit into from
May 30, 2023

Conversation

@Shawyeok
Copy link
Contributor

@Shawyeok Shawyeok commented May 30, 2023 •
edited
Loading

Motivation

This pr is follow suggestion from #20363 (comment), add unit test for #20363

Verifying this change

This change added tests and can be verified as follows:

  • Add MetadataStoreTest#testExistsDistributed for distributed metaStore implementations only
  • Add MetadataStoreTest#testGetChildrenDistributed for distributed metaStore implementations only

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: Shawyeok#8

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 30, 2023
@Technoboy- Technoboy- added this to the 3.1.0 milestone May 30, 2023
@Technoboy- Technoboy- requested a review from poorbarcode May 30, 2023 10:29
@poorbarcode poorbarcode merged commit 113d70d into apache:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

Assignees

@Shawyeok Shawyeok

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Shawyeok @Technoboy- @poorbarcode