Skip to content

Conversation

@cbornet
Copy link
Contributor

@cbornet cbornet commented May 30, 2023

Motivation

Those scripts are not used anymore in the release process

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

as they are not used anymore in the release process
@github-actions github-actions bot added the doc-complete Your PR changes impact docs and the related docs have been already added. label May 30, 2023
@tisonkun
Copy link
Member

@cbornet Thanks for your contribution! As you mark this PR as doc-complete, can you share the related doc page or change set?

@tisonkun tisonkun self-requested a review May 31, 2023 01:48
@nodece
Copy link
Member

nodece commented May 31, 2023

I suggest that we should update the build and publish scripts instead of removing them.

@lhotari
Copy link
Member

lhotari commented May 31, 2023

I suggest that we should update the build and publish scripts instead of removing them.

+1. In addition, it is necessary to handle existing maintenance branches. Otherwise, the "latest" tag will always point to the image that was published last. That should be prevented.

@cbornet
Copy link
Contributor Author

cbornet commented Jun 2, 2023

Closing this one as we will update the scripts instead.

@cbornet cbornet closed this Jun 2, 2023
@nodece
Copy link
Member

nodece commented Jun 2, 2023

See #20462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-complete Your PR changes impact docs and the related docs have been already added. ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants