[fix][broker] Restore solution for certain topic unloading race conditions #20527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… race conditions - solution was introduced in apache#17526 - however, it was accidentially replaced with a call to the incorrect method signature in apache#17736
lhotari
added
type/bug
lhotari
requested review from
eolivelli,
hangc0276,
michaeljmarshall,
nicoloboschi and
poorbarcode
eolivelli
approved these changes
Jun 7, 2023
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Great catch
Removing the old method is good as we won't fall again into the same issue
poorbarcode
approved these changes
Jun 7, 2023
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2023
…tions (apache#20527) (cherry picked from commit 03f9167)
lhotari
added
cherry-picked/branch-2.9
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's possible to get into a situation where there are multiple topic instances for the same topic getting unloaded and loaded in the same broker concurrently.
A solution for addressing this problem was introduced in #17526.
However, the solution was removed in #17736 since the call
brokerService.removeTopicFromCache(PersistentTopic.this)was replaced with the callbrokerService.removeTopicFromCache(topic)since there was the old method signature available in the class.Modifications
brokerService.removeTopicFromCache(PersistentTopic.this)Documentation
docdoc-requireddoc-not-neededdoc-complete