Skip to content

[refactor][cli][PIP-280] Refactor CmdNamespace for parameters with measurement units#20749

Closed
JooHyukKim wants to merge 15 commits intoapache:masterfrom
JooHyukKim:pip280-namespaces
Closed

[refactor][cli][PIP-280] Refactor CmdNamespace for parameters with measurement units#20749
JooHyukKim wants to merge 15 commits intoapache:masterfrom
JooHyukKim:pip280-namespaces

Conversation

@JooHyukKim
Copy link
Copy Markdown
Contributor

PIP: #20691

Motivation

Described in PIP

Modifications

Described in PIP

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/15

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jul 6, 2023
@JooHyukKim JooHyukKim changed the title [refacto][CLI][PIP-280] Refactor CmdNamespace for parameters with measurement units [refactor][CLI][PIP-280] Refactor CmdNamespace for parameters with measurement units Jul 7, 2023
@JooHyukKim JooHyukKim changed the title [refactor][CLI][PIP-280] Refactor CmdNamespace for parameters with measurement units [refactor][cli][PIP-280] Refactor CmdNamespace for parameters with measurement units Jul 7, 2023
@JooHyukKim
Copy link
Copy Markdown
Contributor Author

Will close this one becasue all of following classes have very smiliar changes and so I will try to refactor them all at once.

  • CmdNamespaces.java
  • CmdTopics.java,
  • CmdTopicPolicies.java.

@JooHyukKim JooHyukKim closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant