[refactor][cli][PIP-280] Refactor CmdNamespace for parameters with measurement units#20749
Closed
JooHyukKim wants to merge 15 commits intoapache:masterfrom
JooHyukKim:pip280-namespaces
Closed
[refactor][cli][PIP-280] Refactor CmdNamespace for parameters with measurement units#20749JooHyukKim wants to merge 15 commits intoapache:masterfrom JooHyukKim:pip280-namespaces
CmdNamespace for parameters with measurement units#20749JooHyukKim wants to merge 15 commits intoapache:masterfrom
JooHyukKim:pip280-namespaces
Conversation
This reverts commit 26d3348.
CmdNamespace for parameters with measurement units CmdNamespace for parameters with measurement units
CmdNamespace for parameters with measurement units CmdNamespace for parameters with measurement units
Contributor
Author
|
Will close this one becasue all of following classes have very smiliar changes and so I will try to refactor them all at once.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIP: #20691
Motivation
Described in PIP
Modifications
Described in PIP
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/15