You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If one source connector extends PushSource. An exception was encountered when this source connector consumed the source system data, it had no way to notify the function framework to restart this connector.
Modifications
Abstract BatchPushSource logic to AbstractPushSource.
Let PushSource to extends AbstractPushSource to extend a new method(notifyError).
@shibd Would this PR change the interface for the ecosystem component? If yes, I think we shouldn't add it to branch-3.0.
I remove the label release-3.0.2 first. But feel free to confirm it and add back the label if it's suitable to cherry-pick to the LTS branch.
@shibd Would this PR change the interface for the ecosystem component? If yes, I think we shouldn't add it to branch-3.0. I remove the label release-3.0.2 first. But feel free to confirm it and add back the label if it's suitable to cherry-pick to the LTS branch.
Thanks for your reminder. I remove the release-x label, and patch a PIP design: #20807
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If one source connector extends
PushSource. An exception was encountered when this source connector consumed the source system data, it had no way to notify the function framework to restart this connector.Modifications
BatchPushSourcelogic toAbstractPushSource.PushSourceto extendsAbstractPushSourceto extend a new method(notifyError).Verifying this change
PushSourceTestto cover it.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository