-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][io][branch-3.0] Not restart instance when kafka source poll exception. #20818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaPushSource.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pulsar.io.kafka; | ||
|
|
||
| import java.util.concurrent.LinkedBlockingQueue; | ||
| import org.apache.pulsar.functions.api.Record; | ||
| import org.apache.pulsar.io.core.Source; | ||
|
|
||
| /** | ||
| * Kafka Push Source. | ||
| * To maintain compatibility, we can't pick the PIP-281: https://github.com/apache/pulsar/pull/20807 | ||
| * cherry-pick to the historical version, so the class is implemented in the kafka connector. | ||
| */ | ||
| public abstract class KafkaPushSource<T> implements Source<T> { | ||
|
shibd marked this conversation as resolved.
|
||
|
|
||
| private static class NullRecord implements Record { | ||
| @Override | ||
| public Object getValue() { | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| private static class ErrorNotifierRecord implements Record { | ||
| private Exception e; | ||
| public ErrorNotifierRecord(Exception e) { | ||
| this.e = e; | ||
| } | ||
| @Override | ||
| public Object getValue() { | ||
| return null; | ||
| } | ||
|
|
||
| public Exception getException() { | ||
| return e; | ||
| } | ||
| } | ||
|
|
||
| private LinkedBlockingQueue<Record<T>> queue; | ||
| private static final int DEFAULT_QUEUE_LENGTH = 1000; | ||
| private final NullRecord nullRecord = new NullRecord(); | ||
|
|
||
| public KafkaPushSource() { | ||
| this.queue = new LinkedBlockingQueue<>(this.getQueueLength()); | ||
| } | ||
|
|
||
| @Override | ||
| public Record<T> read() throws Exception { | ||
| Record<T> record = queue.take(); | ||
| if (record instanceof ErrorNotifierRecord) { | ||
| throw ((ErrorNotifierRecord) record).getException(); | ||
| } | ||
| if (record instanceof NullRecord) { | ||
| return null; | ||
| } else { | ||
| return record; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Send this message to be written to Pulsar. | ||
| * Pass null if you you are done with this task | ||
| * @param record next message from source which should be sent to a Pulsar topic | ||
| */ | ||
| public void consume(Record<T> record) { | ||
| try { | ||
| if (record != null) { | ||
| queue.put(record); | ||
| } else { | ||
| queue.put(nullRecord); | ||
| } | ||
| } catch (InterruptedException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Get length of the queue that records are push onto. | ||
| * Users can override this method to customize the queue length | ||
| * @return queue length | ||
| */ | ||
| public int getQueueLength() { | ||
| return DEFAULT_QUEUE_LENGTH; | ||
| } | ||
|
|
||
| /** | ||
| * Allows the source to notify errors asynchronously. | ||
| * @param ex | ||
| */ | ||
| public void notifyError(Exception ex) { | ||
| consume(new ErrorNotifierRecord(ex)); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.