[fix][broker] Fix inconsensus namespace policies by getPoliciesIfCached#20855
Merged
mattisonchao merged 11 commits intoapache:masterfrom Jul 25, 2023
mattisonchao:inconsensus_ns_policy/fix
Merged
[fix][broker] Fix inconsensus namespace policies by getPoliciesIfCached#20855mattisonchao merged 11 commits intoapache:masterfrom mattisonchao:inconsensus_ns_policy/fix
getPoliciesIfCached#20855mattisonchao merged 11 commits intoapache:masterfrom
mattisonchao:inconsensus_ns_policy/fix
Conversation
poorbarcode
reviewed
Jul 24, 2023
Contributor
poorbarcode
left a comment
poorbarcode
left a comment
There was a problem hiding this comment.
Good catch, could you add a test?
poorbarcode
reviewed
Jul 24, 2023
coderzc
approved these changes
Jul 25, 2023
Member
Author
#20843 has already added a test to prove the cache problem. we should avoid using this API to get inconsistent namespace policies. |
poorbarcode
approved these changes
Jul 25, 2023
Technoboy-
approved these changes
Jul 25, 2023
codelipenghui
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#12339 Change some metadata blocking calls to get from the cache. And then #14154 add the cache expires. It will introduce inconsistent namespace policies problem when the cache is missed.
Modifications
getPoliciesIfCachedrelated logic, then usexxxAsyncinstead of it.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete