[improve][txn]Add log when can't send TcClientConnectRequest to broker.#20880
Merged
liangyepianzhou merged 2 commits intoapache:masterfrom Jul 31, 2023
liangyepianzhou:Log_for_proto_version
Merged
[improve][txn]Add log when can't send TcClientConnectRequest to broker.#20880liangyepianzhou merged 2 commits intoapache:masterfrom liangyepianzhou:Log_for_proto_version
liangyepianzhou merged 2 commits intoapache:masterfrom
liangyepianzhou:Log_for_proto_version
Conversation
poorbarcode
approved these changes
Jul 26, 2023
Technoboy-
reviewed
Jul 29, 2023
Codecov Report
@@ Coverage Diff @@
## master #20880 +/- ##
============================================
- Coverage 73.17% 73.08% -0.09%
+ Complexity 32231 32230 -1
============================================
Files 1874 1874
Lines 139302 139379 +77
Branches 15322 15328 +6
============================================
- Hits 101934 101865 -69
- Misses 29311 29462 +151
+ Partials 8057 8052 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lifepuzzlefun
approved these changes
Jul 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Issue: #20851
Motivation
When the Proto version does not allow us to send TcClientConnectRequest to the broker, we should add a log to debug it.
Modifications
Add a waining log.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: