[fix][broker] fix MessageDeduplication throw NPE when enable broker dedup and set namespace disable deduplication.#20905
Merged
Technoboy- merged 1 commit intoapache:masterfrom Aug 1, 2023
Conversation
…level deduplication.
lifepuzzlefun
changed the title
Technoboy-
approved these changes
Jul 31, 2023
dao-jun
approved these changes
Jul 31, 2023
gaoran10
approved these changes
Aug 1, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Aug 1, 2023
…edup and set namespace disable deduplication. (#20905)
Technoboy-
pushed a commit
that referenced
this pull request
Aug 17, 2023
…edup and set namespace disable deduplication. (#20905)
Technoboy-
pushed a commit
that referenced
this pull request
Aug 17, 2023
…edup and set namespace disable deduplication. (#20905)
Technoboy-
pushed a commit
that referenced
this pull request
Aug 17, 2023
…edup and set namespace disable deduplication. (#20905)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20904
Motivation
when enable broker level deduplication and disable namespace level deduplication.
the brokerService checkSnapshotTask will throw npe.
Modifications
if the topic disable deduplication. skip take snapshot of deduplication.
Verifying this change
add unit test in this patch.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: