[improve][io] Improve kinesis connector config.#21004
Merged
Technoboy- merged 2 commits intoapache:masterfrom Aug 22, 2023
Merged
[improve][io] Improve kinesis connector config.#21004Technoboy- merged 2 commits intoapache:masterfrom
Technoboy- merged 2 commits intoapache:masterfrom
Conversation
JooHyukKim
reviewed
Aug 16, 2023
JooHyukKim
reviewed
Aug 16, 2023
JooHyukKim
approved these changes
Aug 16, 2023
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21004 +/- ##
=============================================
+ Coverage 34.80% 72.97% +38.16%
- Complexity 12102 32310 +20208
=============================================
Files 1698 1873 +175
Lines 129852 140705 +10853
Branches 14161 15684 +1523
=============================================
+ Hits 45201 102679 +57478
+ Misses 78646 29866 -48780
- Partials 6005 8160 +2155
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Technoboy-
reviewed
Aug 21, 2023
| help = "Cloudwatch end-point url. It can be found at " | ||
| + "https://docs.aws.amazon.com/general/latest/gr/rande.html" | ||
| ) | ||
| private String cloudwatchEndpoint = ""; |
Member
Author
There was a problem hiding this comment.
To be consistent with the previous name.
Technoboy-
approved these changes
Aug 22, 2023
jiangpengcheng
approved these changes
Aug 22, 2023
freeznet
approved these changes
Aug 22, 2023
14 tasks
Member
|
not cherry-picking since #24495 isn't required for 3.0.x anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve kinesis connector some config.
Modifications
For the kinesis sink connector
cloudwatchEndpointconfig, Because the AWS Kinesis producer will periodically send log metrics to CloudWatch.The current user can set
awsRegionorawsEndpoint, but if the user just setsawsEndpoint, he will encounter an error:For the kinesis source connector
applicationNamedefault value ispulsar-kinesis, If you use the original default values(Apache Pulsar IO Connector), you will encounter an error:For some refactor code:
KinesisSinkConfig.load()method, and move the param verify logic to it.KinesisSourceConfig.load()method, and move the param verify logic to it.AwsCredentialProviderPlugin,AwsDefaultProviderChainPluginandSTSAssumeRoleProviderPluginclass, These classes have long been deprecated, and there is no place to use them.Verifying this change
missCloudWatchEndpointTestto coverawsRegionandcloudwatchEndpointis empty.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository