Skip to content

[improve][proxy] Support disabling metrics endpoint#21031

Merged
michaeljmarshall merged 3 commits intoapache:masterfrom
michaeljmarshall:disable-proxy-stats
Aug 19, 2023
Merged

[improve][proxy] Support disabling metrics endpoint#21031
michaeljmarshall merged 3 commits intoapache:masterfrom
michaeljmarshall:disable-proxy-stats

Conversation

@michaeljmarshall
Copy link
Copy Markdown
Member

Motivation

In certain deployments, it is preferable to be able to disable the /proxy-stats, /metrics, and /status.html endpoints.

Modifications

  • Add configuration named enableProxyStatsEndpoints to the proxy configuration. When true (default), the endpoints are all exposed. When false, they are not served.
  • Fix some implementation details for the proxy stats servlet configuration and the endpoints themselves

Verifying this change

This is a minor change.

Documentation

  • doc-not-needed

@michaeljmarshall michaeljmarshall added area/proxy doc-not-needed Your PR changes do not impact docs ready-to-test labels Aug 19, 2023
@michaeljmarshall michaeljmarshall added this to the 3.2.0 milestone Aug 19, 2023
@michaeljmarshall michaeljmarshall self-assigned this Aug 19, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 19, 2023

Codecov Report

❌ Patch coverage is 55.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.11%. Comparing base (0cb1c78) to head (adc0b37).
⚠️ Report is 1738 commits behind head on master.

Files with missing lines Patch % Lines
...java/org/apache/pulsar/proxy/stats/ProxyStats.java 23.80% 15 Missing and 1 partial ⚠️
...pache/pulsar/proxy/server/ProxyServiceStarter.java 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21031       +/-   ##
=============================================
+ Coverage     33.56%   73.11%   +39.55%     
- Complexity    12198    32174    +19976     
=============================================
  Files          1621     1875      +254     
  Lines        126970   139505    +12535     
  Branches      13857    15344     +1487     
=============================================
+ Hits          42618   102001    +59383     
+ Misses        78748    29436    -49312     
- Partials       5604     8068     +2464     
Flag Coverage Δ
inttests 24.27% <30.00%> (+0.03%) ⬆️
systests 25.09% <30.00%> (?)
unittests 72.41% <55.00%> (+40.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...apache/pulsar/proxy/server/ProxyConfiguration.java 97.56% <100.00%> (+28.70%) ⬆️
...java/org/apache/pulsar/proxy/server/WebServer.java 78.52% <100.00%> (+11.04%) ⬆️
...pache/pulsar/proxy/server/ProxyServiceStarter.java 65.33% <75.00%> (+23.05%) ⬆️
...java/org/apache/pulsar/proxy/stats/ProxyStats.java 51.06% <23.80%> (+51.06%) ⬆️

... and 1516 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michaeljmarshall michaeljmarshall merged commit d06cda6 into apache:master Aug 19, 2023
@michaeljmarshall michaeljmarshall deleted the disable-proxy-stats branch August 19, 2023 15:03
michaeljmarshall added a commit that referenced this pull request Aug 24, 2023
michaeljmarshall added a commit that referenced this pull request Aug 24, 2023
michaeljmarshall added a commit to datastax/pulsar that referenced this pull request Aug 24, 2023
(cherry picked from commit d06cda6)
(cherry picked from commit c644849)
(cherry picked from commit 084347c)
michaeljmarshall added a commit that referenced this pull request Aug 24, 2023
(cherry picked from commit d06cda6)
(cherry picked from commit c644849)
michaeljmarshall added a commit that referenced this pull request Aug 24, 2023
@mattisonchao mattisonchao mentioned this pull request Sep 6, 2023
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
(cherry picked from commit d06cda6)
(cherry picked from commit c644849)
(cherry picked from commit 084347c)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 11, 2024
(cherry picked from commit d06cda6)
(cherry picked from commit c644849)
(cherry picked from commit 084347c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants