[refactor][cli][PIP-280] Add missing pulsar-cli-utils module registration in Maven core-modules profile#21062
Merged
tisonkun merged 2 commits intoapache:masterfrom Aug 30, 2023
JooHyukKim:PIP280-Fix-build-failure
Merged
[refactor][cli][PIP-280] Add missing pulsar-cli-utils module registration in Maven core-modules profile#21062tisonkun merged 2 commits intoapache:masterfrom JooHyukKim:PIP280-Fix-build-failure
pulsar-cli-utils module registration in Maven core-modules profile#21062tisonkun merged 2 commits intoapache:masterfrom
JooHyukKim:PIP280-Fix-build-failure
Conversation
15 tasks
tisonkun
approved these changes
Aug 24, 2023
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Interesting. Why do the original PR gets passed on CI?
Contributor
Author
Member
|
@JooHyukKim I get the point. |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21062 +/- ##
=============================================
+ Coverage 33.52% 73.16% +39.63%
- Complexity 12221 32385 +20164
=============================================
Files 1623 1887 +264
Lines 127275 139855 +12580
Branches 13897 15382 +1485
=============================================
+ Hits 42671 102319 +59648
+ Misses 78986 29437 -49549
- Partials 5618 8099 +2481
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
There has been a couple of CVE-related version bumps. This PR should pass now. |
Member
|
Merging... Keep going @JooHyukKim! |
Contributor
Author
Thankssss! 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 🔗build failure in #20764,
Motivation
As title describes. Current change should have been part of #20782, my apologies for missing out 🙏🏼.
Modifications
As title describes.
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/22