Skip to content

[fix][broker] Use expireAfterAccess instead of expireAfterWrite for metadata cache #21095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codelipenghui wants to merge 1 commit into from
Closed

[fix][broker] Use expireAfterAccess instead of expireAfterWrite for metadata cache #21095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCacheConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,12 @@ public class MetadataCacheConfig {
* A negative or zero value disables automatic expiration.
*/
@Builder.Default
private final long expireAfterWriteMillis = 2 * DEFAULT_CACHE_REFRESH_TIME_MILLIS;
private final long expireAfterWriteMillis = 0L;
Copy link
Copy Markdown
Contributor

@hangc0276 hangc0276 Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the default value to -1. Use -1 to disable the expire maybe better to understand.


/**
* Specifies that each entry should be automatically removed from the cache once a fixed duration
* has elapsed after the entry's creation, the most recent replacement of its value, or its last access.
* A negative or zero value disables automatic expiration.
*/
private final long expireAfterAccessMillis = 2 * DEFAULT_CACHE_REFRESH_TIME_MILLIS;
}
3 changes: 3 additions & 0 deletions pulsar-metadata/src/main/java/org/apache/pulsar/metadata/cache/impl/MetadataCacheImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ public MetadataCacheImpl(MetadataStore store, MetadataSerde<T> serde, MetadataCa
if (cacheConfig.getExpireAfterWriteMillis() > 0) {
cacheBuilder.expireAfterWrite(cacheConfig.getExpireAfterWriteMillis(), TimeUnit.MILLISECONDS);
}
if (cacheConfig.getExpireAfterAccessMillis() > 0) {
cacheBuilder.expireAfterAccess(cacheConfig.getExpireAfterAccessMillis(), TimeUnit.MILLISECONDS);
}
this.objCache = cacheBuilder
.buildAsync(new AsyncCacheLoader<String, Optional<CacheGetResult<T>>>() {
@Override
Expand Down