-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][ws] Support subscribing multi/pattern topic for Websocket #21379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][ws] Support subscribing multi/pattern topic for Websocket #21379
Conversation
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/MultiTopicConsumerHandler.java
Outdated
Show resolved
Hide resolved
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPublishConsumeTest.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPublishConsumeTest.java
Show resolved
Hide resolved
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java
Outdated
Show resolved
Hide resolved
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java
Show resolved
Hide resolved
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/MultiTopicConsumerHandler.java
Outdated
Show resolved
Hide resolved
mattisonchao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overal LGTM.
|
Please help fix the checkstyle issue. |
59e07f7 to
6caf1ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21379 +/- ##
============================================
- Coverage 73.29% 73.25% -0.05%
- Complexity 32505 32609 +104
============================================
Files 1890 1892 +2
Lines 140381 140444 +63
Branches 15425 15436 +11
============================================
- Hits 102898 102878 -20
- Misses 29405 29475 +70
- Partials 8078 8091 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
PIP-306
Motivation
Support subscribing multi/pattern topic for WS.
The new sub-path could be :
Documentation
docdoc-requireddoc-not-neededdoc-complete