Skip to content

Conversation

@Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Oct 17, 2023

PIP-306

Motivation

Support subscribing multi/pattern topic for WS.
The new sub-path could be :

/ws/v3/consumer/subscription?topicsPattern="a.*" /ws/v3/consumer/subscription?topics="a,b,c"

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Oct 17, 2023
@Technoboy- Technoboy- added this to the 3.2.0 milestone Oct 17, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 17, 2023
Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overal LGTM.

@mattisonchao
Copy link
Member

Please help fix the checkstyle issue.

@Technoboy- Technoboy- force-pushed the support-multi-topic-consume-for-ws branch from 59e07f7 to 6caf1ec Compare October 30, 2023 02:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Attention: Patch coverage is 58.82353% with 28 lines in your changes missing coverage. Please review.

Project coverage is 73.25%. Comparing base (bd86e4e) to head (6caf1ec).
Report is 1412 commits behind head on master.

Files with missing lines Patch % Lines
...he/pulsar/websocket/MultiTopicConsumerHandler.java 38.63% 22 Missing and 5 partials ⚠️
.../websocket/WebSocketMultiTopicConsumerServlet.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21379      +/-   ##
============================================
- Coverage     73.29%   73.25%   -0.05%     
- Complexity    32505    32609     +104     
============================================
  Files          1890     1892       +2     
  Lines        140381   140444      +63     
  Branches      15425    15436      +11     
============================================
- Hits         102898   102878      -20     
- Misses        29405    29475      +70     
- Partials       8078     8091      +13     
Flag Coverage Δ
inttests 24.14% <23.52%> (+0.04%) ⬆️
systests 24.72% <13.23%> (-0.22%) ⬇️
unittests 72.54% <55.88%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/java/org/apache/pulsar/broker/PulsarService.java 83.07% <100.00%> (+0.14%) ⬆️
...pache/pulsar/proxy/server/ProxyServiceStarter.java 66.44% <100.00%> (+0.44%) ⬆️
...che/pulsar/websocket/AbstractWebSocketHandler.java 57.55% <100.00%> (+0.30%) ⬆️
...a/org/apache/pulsar/websocket/ConsumerHandler.java 63.09% <100.00%> (+0.59%) ⬆️
...sar/websocket/service/WebSocketServiceStarter.java 74.46% <100.00%> (+0.55%) ⬆️
.../websocket/WebSocketMultiTopicConsumerServlet.java 88.88% <88.88%> (ø)
...he/pulsar/websocket/MultiTopicConsumerHandler.java 38.63% <38.63%> (ø)

... and 79 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Technoboy- Technoboy- merged commit eebd821 into apache:master Nov 6, 2023
@Technoboy- Technoboy- deleted the support-multi-topic-consume-for-ws branch November 11, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/websocket doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants