[improve][cli][PIP-280] Retrofit pulsar-cli-utils into pulsar-broker and pulsar-client-tools

[JooHyukKim]

• Main Issue: [refactor][cli][PIP-280] Tracker : Refactor byte, time parsing logic using new pulsar-cli-utils module #21056
• PIP: [pip][design] PIP-280: Refactor CLI for measurement units (time, byte) #20691

Motivation

• Retrofit pulsar-cli-utils into pulsar-broker and pulsar-client-tools.
• This seems to cover last bits of refactor around time and byte-unit.

Modifications

• Made TokensCliUtils in pulsar-broker module to delegate time parsing logic to pulsar-cli-utils.
• Same as above, but to CmdPersistentTopics

Verifying this change

• Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/23/

[JooHyukKim]

This seems to cover last bits of refactor around time and byte-unit.

/cc @tisonkun, WDYT?

[tisonkun]

LGTM.

Out thread - I found that RelativeTimeUtil is duplicated in pulsar-common and pulsar-cli-utils. What's the reason, and if we can eliminate the duplicate?

[JooHyukKim]

WRT failing tests, they are flakey since they all pass in my fork.

[JooHyukKim]

Out of thread - I noticed that RelativeTimeUtil is duplicated in both pulsar-common and pulsar-cli-utils. Is there a specific reason for this? Can we eliminate the duplication?

Indeed, RelativeTimeUtil is duplicated. However, I suggest we retain it.

The rationale is that the duplication serves as a small trade-off to avoid introducing a dependency between the two modules.

Furthermore, the likelihood of changes to the RelativeTimeUtil implementation is quite low, making the cost of this duplication minimal.

[tisonkun]

WRT failing tests, they are flakey since they all pass in my fork.

Lari fixes an amount of flaky tests these days, you can merge master and push this branch to retrigger the CI.

[tisonkun]

LGTM.

[tisonkun]

Merging..