[fix][test] Fix thread leaks related to unclosed WebSocketService #21453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
BewareMyPower,
Technoboy-,
gaoran10,
mattisonchao,
nodece,
poorbarcode and
tisonkun
nodece
approved these changes
Oct 27, 2023
lhotari
force-pushed
the
lh-fix-WebSocketService-closing
branch
from
94fcc76 to
09ef5f6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21453 +/- ##
============================================
- Coverage 73.31% 73.21% -0.10%
+ Complexity 32599 32565 -34
============================================
Files 1890 1890
Lines 140357 140357
Branches 15425 15425
============================================
- Hits 102903 102765 -138
- Misses 29361 29495 +134
- Partials 8093 8097 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
dao-jun
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are a few tests where threads are leaked since WebSocketService isn't closed.
Additional context
This type of issues can now be detected with #21450 improvements to CI.
Modifications
Close WebSocketService properly in tests.
Documentation
docdoc-requireddoc-not-neededdoc-complete