[fix][test] Fix multiple thread leaks in tests #21460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
315157973,
BewareMyPower,
Technoboy-,
mattisonchao,
michaeljmarshall and
tisonkun
lhotari
force-pushed
the
lh-fix-multiple-thread-leaks-in-tests
branch
2 times, most recently
from
41a45ea to
8d65874
Compare
lhotari
force-pushed
the
lh-fix-multiple-thread-leaks-in-tests
branch
from
8d65874 to
71b038f
Compare
Technoboy-
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Each test should properly close the resources that it creates. Leaked resources consume memory and can also consume CPU and cause test flakiness. This PR continues fixing thread leaks in tests detected with the thread leak detection solution part of PR #21450.
Modifications
Property close resources in tests.
Documentation
docdoc-requireddoc-not-neededdoc-complete