Skip to content

[fix][test] Fix multiple thread leaks in tests #21500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhotari merged 11 commits into from
Nov 2, 2023
Merged

[fix][test] Fix multiple thread leaks in tests #21500

lhotari merged 11 commits into from
Nov 2, 2023

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Nov 1, 2023

Motivation

There are thread leaks in tests reported by the thread leak detection added in #21450.

Modifications

Fix multiple thread leaks in unit tests.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari self-assigned this Nov 1, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 1, 2023
@lhotari lhotari force-pushed the lh-fix-even-more-thread-leaks-in-tests branch from bca0597 to 37ac67c Compare November 1, 2023 22:07
cbornet
cbornet approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@cbornet cbornet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@cbornet
Copy link
Contributor

cbornet commented Nov 1, 2023

There's a failing test. Can you check ?

@lhotari
Copy link
Member Author

lhotari commented Nov 1, 2023 •
edited
Loading

There's a failing test. Can you check ?

@cbornet there was a flaky test and in addition the JVM crashed due to #19307. I wrote about the JVM crash on the dev mailing list yesterday.

@lhotari lhotari merged commit c3f954e into apache:master Nov 2, 2023
nborisov pushed a commit to nborisov/pulsar that referenced this pull request Nov 13, 2023
@lhotari
[fix][test] Fix multiple thread leaks in tests (apache#21500)
596a477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbornet cbornet cbornet approved these changes

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

@tisonkun tisonkun Awaiting requested review from tisonkun

@coderzc coderzc Awaiting requested review from coderzc

@mattisonchao mattisonchao Awaiting requested review from mattisonchao

Assignees

@lhotari lhotari

Labels

area/test doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lhotari @cbornet