Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Nov 8, 2023

Motivation

There are thread leaks in tests reported by the thread leak detection added in #21450.

Modifications

Fix multiple thread leaks in unit tests.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.2.0 milestone Nov 8, 2023
@lhotari lhotari self-assigned this Nov 8, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 8, 2023
@lhotari lhotari force-pushed the lh-fix-even-more-thread-leaks-in-tests-3 branch from 3b42751 to 7f48960 Compare November 8, 2023 10:50
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.23%. Comparing base (428c18c) to head (7f48960).
⚠️ Report is 1523 commits behind head on master.

Files with missing lines Patch % Lines
...ker/authentication/AuthenticationProviderSasl.java 66.66% 0 Missing and 1 partial ⚠️
...rg/apache/pulsar/common/sasl/TGTRefreshThread.java 0.00% 0 Missing and 1 partial ⚠️
...esystem/impl/FileSystemManagedLedgerOffloader.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21543       +/-   ##
=============================================
+ Coverage     36.62%   73.23%   +36.61%     
- Complexity    12205    32673    +20468     
=============================================
  Files          1715     1892      +177     
  Lines        131092   140702     +9610     
  Branches      14300    15478     +1178     
=============================================
+ Hits          48015   103047    +55032     
+ Misses        76707    29545    -47162     
- Partials       6370     8110     +1740     
Flag Coverage Δ
inttests 24.08% <0.00%> (-0.14%) ⬇️
systests 24.64% <0.00%> (-0.15%) ⬇️
unittests 72.54% <72.72%> (+40.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...he/pulsar/client/impl/auth/AuthenticationSasl.java 69.50% <100.00%> (+69.50%) ⬆️
...ker/authentication/AuthenticationProviderSasl.java 59.23% <66.66%> (+59.23%) ⬆️
...rg/apache/pulsar/common/sasl/TGTRefreshThread.java 25.92% <0.00%> (+25.92%) ⬆️
...esystem/impl/FileSystemManagedLedgerOffloader.java 69.38% <50.00%> (ø)

... and 1455 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lhotari lhotari merged commit 51202a6 into apache:master Nov 8, 2023
nborisov pushed a commit to nborisov/pulsar that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants