Skip to content

[improve][sec] Revert "Add group pulsar and add user pulsar to it instead of root"#21691

Merged
michaeljmarshall merged 1 commit intoapache:masterfrom
yaalsn:revert-21084-gid-rootless
Dec 8, 2023
Merged

[improve][sec] Revert "Add group pulsar and add user pulsar to it instead of root"#21691
michaeljmarshall merged 1 commit intoapache:masterfrom
yaalsn:revert-21084-gid-rootless

Conversation

@yaalsn
Copy link
Contributor

@yaalsn yaalsn commented Dec 8, 2023

Motivation

Reverts #21084. Because the change breaks OpenShift support.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 8, 2023
@zymap zymap added this to the 3.2.0 milestone Dec 8, 2023
@yaalsn yaalsn changed the title Revert "[improve][sec] Add group pulsar and add user pulsar to it instead of root" [improve][sec] Revert "Add group pulsar and add user pulsar to it instead of root" Dec 8, 2023
@yaalsn yaalsn closed this Dec 8, 2023
@yaalsn yaalsn reopened this Dec 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #21691 (2c117bb) into master (f25b082) will increase coverage by 38.90%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21691       +/-   ##
=============================================
+ Coverage     34.49%   73.39%   +38.90%     
- Complexity    12116    32751    +20635     
=============================================
  Files          1716     1893      +177     
  Lines        131152   140754     +9602     
  Branches      14327    15503     +1176     
=============================================
+ Hits          45236   103307    +58071     
+ Misses        79828    29343    -50485     
- Partials       6088     8104     +2016     
Flag Coverage Δ
inttests 24.11% <28.57%> (?)
systests 24.70% <28.57%> (-0.03%) ⬇️
unittests 72.69% <100.00%> (+40.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 80.78% <100.00%> (+34.60%) ⬆️
...org/apache/pulsar/broker/ServiceConfiguration.java 99.38% <100.00%> (+1.32%) ⬆️
...rg/apache/pulsar/compaction/TwoPhaseCompactor.java 73.94% <100.00%> (+5.88%) ⬆️

... and 1476 files with indirect coverage changes

@michaeljmarshall michaeljmarshall merged commit 7e76c45 into apache:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants