Skip to content

Conversation

@graysonzeng
Copy link
Contributor

Fixes #17061

Main Issue: #17061

Motivation

The batch message will generate the same sequence ID in the function, which will cause a large amount of data in the batch message to be mistakenly deduplicated when EFFECTIVELY_ONCE mode and enable message deduplication.

Modifications

Use Interceptor with org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor and enable exusingBrokerEntryMetadataToClientEnabled on the broker。In the batch message we can generate the sequenceId of the sequence and get it using record.getSequenceId()

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 28, 2023
@graysonzeng graysonzeng changed the title [improve] EFFECTIVELY_ONCE mode support input topic batching [improve][functions] EFFECTIVELY_ONCE mode support input topic batching Dec 28, 2023
@Technoboy- Technoboy- requested a review from freeznet December 28, 2023 11:57
@graysonzeng
Copy link
Contributor Author

@jiangpengcheng @freeznet PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

function EFFECTIVELY_ONCE cannot support input topic batching

2 participants