Skip to content

Conversation

@Apurva007
Copy link
Contributor

@Apurva007 Apurva007 commented Feb 2, 2024

PIP-337: Create a new SSL Factory Plugin to customize SSL Context and SSL Engine Generation

Motivation

Apache Pulsar's TLS encryption configuration is not pluggable. It only supports file-based certificates. This makes
Pulsar difficult to adopt for organizations that require loading TLS certificates by other mechanisms.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added type/PIP doc-not-needed Your PR changes do not impact docs labels Feb 2, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal. This is very useful. I added some comments about the detailed design.

@Apurva007 Apurva007 force-pushed the pip-337-ssl-plugin branch from fa45432 to f073d4b Compare June 25, 2024 18:40
@github-actions github-actions bot added the PIP label Jun 25, 2024
@Apurva007 Apurva007 force-pushed the pip-337-ssl-plugin branch from f073d4b to 66fdc70 Compare June 25, 2024 21:55
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PIP was approved

@merlimat merlimat merged commit 2086cc4 into apache:master Jul 4, 2024
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
…nd SSL Engine generation (apache#22016)

Co-authored-by: Apurva Telang <atelang@paypal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs PIP type/PIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants