Skip to content

Conversation

@jiangpengcheng
Copy link
Contributor

Fixes #xyz

Main Issue: #xyz

PIP: #22071

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

  • This change added tests and can be verified as follows:

(example:)

  • Added unittests for setting log-topic and update log-topic

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: jiangpengcheng#27

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Mar 4, 2024
@Technoboy- Technoboy- requested a review from freeznet March 7, 2024 11:45
@Technoboy- Technoboy- added this to the 3.3.0 milestone Mar 7, 2024
@Technoboy- Technoboy- closed this Mar 7, 2024
@Technoboy- Technoboy- reopened this Mar 7, 2024
@Technoboy- Technoboy- closed this Mar 13, 2024
@Technoboy- Technoboy- reopened this Mar 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 57.69231% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.43%. Comparing base (bbc6224) to head (3725ab1).
Report is 1208 commits behind head on master.

Files with missing lines Patch % Lines
...ache/pulsar/functions/utils/SourceConfigUtils.java 60.00% 3 Missing and 1 partial ⚠️
...apache/pulsar/functions/utils/SinkConfigUtils.java 70.00% 2 Missing and 1 partial ⚠️
...ain/java/org/apache/pulsar/admin/cli/CmdSinks.java 0.00% 1 Missing and 1 partial ⚠️
...n/java/org/apache/pulsar/admin/cli/CmdSources.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22185      +/-   ##
============================================
- Coverage     73.57%   73.43%   -0.14%     
+ Complexity    32624    32526      -98     
============================================
  Files          1877     1879       +2     
  Lines        139502   141627    +2125     
  Branches      15299    15730     +431     
============================================
+ Hits         102638   104004    +1366     
- Misses        28908    29528     +620     
- Partials       7956     8095     +139     
Flag Coverage Δ
inttests 27.19% <0.00%> (+2.61%) ⬆️
systests 24.82% <7.69%> (+0.50%) ⬆️
unittests 72.62% <57.69%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/java/org/apache/pulsar/common/io/SinkConfig.java 94.59% <100.00%> (+0.15%) ⬆️
...java/org/apache/pulsar/common/io/SourceConfig.java 95.83% <100.00%> (+0.18%) ⬆️
...ain/java/org/apache/pulsar/admin/cli/CmdSinks.java 43.18% <0.00%> (-0.29%) ⬇️
...n/java/org/apache/pulsar/admin/cli/CmdSources.java 46.15% <0.00%> (-0.33%) ⬇️
...apache/pulsar/functions/utils/SinkConfigUtils.java 74.32% <70.00%> (-0.10%) ⬇️
...ache/pulsar/functions/utils/SourceConfigUtils.java 67.30% <60.00%> (-0.25%) ⬇️

... and 111 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Technoboy- Technoboy- merged commit 392549c into apache:master Mar 13, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required Your PR changes impact docs and you will update later. ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants