[improve][cli] PIP-343: Use picocli instead of jcommander in pulsar-client-tools#22209
Merged
nodece merged 4 commits intoapache:masterfrom Mar 14, 2024
Merged
Conversation
nodece
force-pushed
the
pip-343-pulsar-client-tools
branch
from
f91d861 to
bcf099f
Compare
19 tasks
Technoboy-
reviewed
Mar 7, 2024
Member
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot rerun-failure-checks |
2 tasks
Technoboy-
approved these changes
Mar 14, 2024
Contributor
Technoboy-
left a comment
Technoboy-
left a comment
There was a problem hiding this comment.
LGTM
Test some methods and it works
dao-jun
reviewed
Mar 14, 2024
Member
dao-jun
left a comment
dao-jun
left a comment
There was a problem hiding this comment.
over all lgtm, just a few minor comments.
Member
Author
|
Ping @dao-jun |
…lient-tools Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
pip-343-pulsar-client-tools
branch
from
707bfdb to
96ab103
Compare
Member
Author
|
/pulsarbot rerun-failure-checks |
15 tasks
4 tasks
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…lient-tools (apache#22209) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIP: #22181
Motivation
Improve CLI user experience.
Due to the large scope of refactoring, I need to split the PR.
Modifications
org.apache.pulsar.admin.cli.utilstoorg.apache.pulsar.admin.cli.utils.picoclivalidateValueWithis ignored, and not be supported by picocliVerifying this change
Relying on existing tests for validation.
Documentation
docdoc-requireddoc-not-neededdoc-complete