Skip to content

[improve][cli] PIP-343: Use picocli instead of jcommander in pulsar-perf#22303

Merged
Technoboy- merged 10 commits intoapache:masterfrom
crossoverJie:pip-343-pulsar-perf
Mar 22, 2024
Merged

[improve][cli] PIP-343: Use picocli instead of jcommander in pulsar-perf#22303
Technoboy- merged 10 commits intoapache:masterfrom
crossoverJie:pip-343-pulsar-perf

Conversation

@crossoverJie
Copy link
Copy Markdown
Member

PIP: #22181
Improve CLI: pulsar-perf user experience.

Motivation

Modifications

  • Refactor the pulsar-perf code.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: crossoverJie#21

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Mar 19, 2024
@crossoverJie
Copy link
Copy Markdown
Member Author

@nodece PTAL

crossoverJie and others added 8 commits March 19, 2024 23:18
…mdGenerateDocumentation.java

Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…ositiveNumberParameterConvert.java

Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…erformanceTransaction.java

Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…erformanceReader.java

Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…erformanceConsumer.java

Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…anagedLedgerWriter.java

Co-authored-by: Zixuan Liu <nodeces@gmail.com>
Copy link
Copy Markdown
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece
Copy link
Copy Markdown
Member

nodece commented Mar 20, 2024

/pulsarbot rerun-failure-checks

@Technoboy- Technoboy- merged commit 69c45ad into apache:master Mar 22, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants