[improve][cli] PIP-343: Refactor pulsar-perf to subcommand#22388
Merged
nodece merged 10 commits intoapache:masterfrom May 2, 2024
Merged
[improve][cli] PIP-343: Refactor pulsar-perf to subcommand#22388nodece merged 10 commits intoapache:masterfrom
nodece merged 10 commits intoapache:masterfrom
Conversation
Member
Author
|
@nodece PTAL. |
nodece
requested changes
Apr 5, 2024
…/client/PerformanceClient.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
nodece
requested changes
Apr 15, 2024
nodece
reviewed
Apr 15, 2024
Member
|
This PR is a bit large and not easy to review. We may need to review multiple times to reach an agreement, thanks. |
Member
Author
Yes, most of them are some template type modifications, which require more patience to do code review. |
nodece
reviewed
Apr 17, 2024
nodece
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIP: #22181
Improve CLI:
pulsar-perfuser experience.Motivation
Refactor
pulsar-perfto subcommand.Modifications
PulsarPerfTestToolpulsar-perfandpulsar-perf.cmdVerifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: crossoverJie#22