[improve] [pip] PIP-349: Add additionalSystemCursorNames ignore list for TTL check #22651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
codelipenghui,
horizonzy,
lhotari,
merlimat,
poorbarcode and
zymap
hangc0276
added
type/PIP
and removed
doc-not-needed
15 tasks
poorbarcode
approved these changes
May 6, 2024
dao-jun
approved these changes
May 6, 2024
hangc0276
changed the title
RobertIndie
reviewed
May 8, 2024
Member
RobertIndie
left a comment
RobertIndie
left a comment
There was a problem hiding this comment.
I think it's better to clearly state that we're adding a new item for the service configuration.
Technoboy-
approved these changes
May 9, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…for TTL check (apache#22651) Co-authored-by: Jiwe Guo <technoboy@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: