[improve][build] Support custom image and label names #22703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
github-actions
bot
added
the
doc-required
lhotari
approved these changes
May 13, 2024
lhotari
reviewed
May 14, 2024
lhotari
requested changes
May 14, 2024
Member
lhotari
left a comment
lhotari
left a comment
There was a problem hiding this comment.
Check the comment for the latest-version-image name
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
Member
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot rerun-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22703 +/- ##
============================================
- Coverage 73.57% 73.17% -0.41%
+ Complexity 32624 32531 -93
============================================
Files 1877 1889 +12
Lines 139502 141392 +1890
Branches 15299 15516 +217
============================================
+ Hits 102638 103460 +822
- Misses 28908 29928 +1020
- Partials 7956 8004 +48
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
@lhotari CI has been passed. |
lhotari
approved these changes
May 15, 2024
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 15, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 16, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to nodece/pulsar
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
that referenced
this pull request
Oct 29, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Dec 3, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Jan 7, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Feb 17, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 7befb8d) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When pushing pulsar and pulsar-all to a custom repository, I don't want to use the original name. If we can support custom image and label names, it will reduce the workload of copying.
Modifications
docker.imageproperty to define the image name, default topulsardocker.tagproperty to define the tag name, default tolatestdocker.imageanddocker.tagto the pulsar, pulsar-all, java-test-image, latest-version-imageDocumentation
docdoc-requireddoc-not-neededdoc-complete