Skip to content

Conversation

@thetumbled
Copy link
Member

@thetumbled thetumbled commented May 13, 2024

Motivation

fix typo and useless local variable.

Modifications

fix typo and useless local variable.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 13, 2024
@thetumbled thetumbled changed the title [fix] [broker] typo [fix] [broker] fix typo and useless local variable. May 13, 2024
@thetumbled
Copy link
Member Author

PTAL, thanks. @lhotari @Technoboy- @dao-jun

@thetumbled
Copy link
Member Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.20%. Comparing base (bbc6224) to head (82f7eae).
⚠️ Report is 1339 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22704      +/-   ##
============================================
- Coverage     73.57%   73.20%   -0.38%     
- Complexity    32624    32858     +234     
============================================
  Files          1877     1889      +12     
  Lines        139502   141392    +1890     
  Branches      15299    15516     +217     
============================================
+ Hits         102638   103502     +864     
- Misses        28908    29909    +1001     
- Partials       7956     7981      +25     
Flag Coverage Δ
inttests 27.46% <ø> (+2.87%) ⬆️
systests 24.75% <ø> (+0.43%) ⬆️
unittests 72.22% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../persistent/ReplicatedSubscriptionsController.java 70.14% <ø> (-2.45%) ⬇️

... and 357 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dao-jun dao-jun added this to the 3.4.0 milestone May 14, 2024
@dao-jun dao-jun merged commit 9f1325a into apache:master May 14, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants