[cleanup][broker] Remove warn logs when changing the state from Owned to Free (Extensible LB) #22708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Free (Extensible LB)
BewareMyPower
requested review from
Demogorgon314,
RobertIndie,
gaoran10,
heesung-sohn and
lhotari
BewareMyPower
added
type/cleanup
Demogorgon314
approved these changes
May 14, 2024
Technoboy-
approved these changes
May 14, 2024
RobertIndie
approved these changes
May 15, 2024
heesung-sohn
approved these changes
May 15, 2024
dao-jun
approved these changes
May 15, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
… to Free (Extensible LB) (apache#22708)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are many warn logs ("Empty selected broker for ownership") when closing the last broker. However, this log should not be warn because it's expected.
Modifications
selectBrokerreturns an empty optional string because the following log "Overriding ownership" will reflect this case by showing the state is changed from Owned to Free.getOverrideInactiveBrokerStateData, which uses Optional as a parameter. See discussion here: https://stackoverflow.com/questions/31922866/why-should-java-8s-optional-not-be-used-in-argumentsDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: