[improve][client] Deprecate MessageIdUtils.getOffset and MessageIdUtils.getMessageId#22747
Merged
RobertIndie merged 1 commit intoapache:masterfrom May 21, 2024
Merged
Conversation
…Utils.getMessageId`
14 tasks
BewareMyPower
approved these changes
May 20, 2024
dao-jun
approved these changes
May 20, 2024
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22747 +/- ##
============================================
- Coverage 73.57% 73.17% -0.40%
+ Complexity 32624 32560 -64
============================================
Files 1877 1889 +12
Lines 139502 141419 +1917
Branches 15299 15518 +219
============================================
+ Hits 102638 103486 +848
- Misses 28908 29936 +1028
- Partials 7956 7997 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…Utils.getMessageId` (apache#22747) ### Motivation After discussing [here](apache#22698 (comment)), the pulsar client shouldn't expose the `offset` term to users. ### Modifications - Deprecate `MessageIdUtils.getOffset` and `MessageIdUtils.getMessageId` - For connectors, use `FunctionCommon.getOffset` and `FunctionCommon.getMessageId`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After discussing here, the pulsar client shouldn't expose the
offsetterm to users.Modifications
MessageIdUtils.getOffsetandMessageIdUtils.getMessageIdFunctionCommon.getOffsetandFunctionCommon.getMessageIdVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: