Skip to content

[fix][cli] Remove defaultValue of tenant/namespace for CmdFunctions #22764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodece merged 1 commit into from
May 23, 2024
Merged

[fix][cli] Remove defaultValue of tenant/namespace for CmdFunctions #22764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,10 @@ void processArguments() throws Exception {}
*/
@Getter
abstract class NamespaceCommand extends BaseCommand {
@Option(names = "--tenant", description = "The tenant of a Pulsar Function",
defaultValue = PUBLIC_TENANT)
@Option(names = "--tenant", description = "The tenant of a Pulsar Function")
protected String tenant;

@Option(names = "--namespace", description = "The namespace of a Pulsar Function",
defaultValue = DEFAULT_NAMESPACE)
@Option(names = "--namespace", description = "The namespace of a Pulsar Function")
protected String namespace;
}

Expand All @@ -117,12 +115,10 @@ abstract class FunctionCommand extends BaseCommand {
@Option(names = "--fqfn", description = "The Fully Qualified Function Name (FQFN) for the function")
protected String fqfn;

@Option(names = "--tenant", description = "The tenant of a Pulsar Function",
defaultValue = PUBLIC_TENANT)
@Option(names = "--tenant", description = "The tenant of a Pulsar Function")
protected String tenant;

@Option(names = "--namespace", description = "The namespace of a Pulsar Function",
defaultValue = DEFAULT_NAMESPACE)
@Option(names = "--namespace", description = "The namespace of a Pulsar Function")
protected String namespace;

@Option(names = "--name", description = "The name of a Pulsar Function")
Expand Down Expand Up @@ -170,11 +166,9 @@ abstract class FunctionDetailsCommand extends BaseCommand {
@Option(names = "--fqfn", description = "The Fully Qualified Function Name (FQFN) for the function"
+ " #Java, Python")
protected String fqfn;
@Option(names = "--tenant", description = "The tenant of a Pulsar Function #Java, Python, Go",
defaultValue = PUBLIC_TENANT)
@Option(names = "--tenant", description = "The tenant of a Pulsar Function #Java, Python, Go")
protected String tenant;
@Option(names = "--namespace", description = "The namespace of a Pulsar Function #Java, Python, Go",
defaultValue = DEFAULT_NAMESPACE)
@Option(names = "--namespace", description = "The namespace of a Pulsar Function #Java, Python, Go")
protected String namespace;
@Option(names = "--name", description = "The name of a Pulsar Function #Java, Python, Go")
protected String functionName;
Expand Down