[fix] [txn] do not take snapshot when no txn.#23009
Closed
thetumbled wants to merge 7 commits intoapache:masterfrom
Closed
[fix] [txn] do not take snapshot when no txn.#23009thetumbled wants to merge 7 commits intoapache:masterfrom
thetumbled wants to merge 7 commits intoapache:masterfrom
Conversation
|
@thetumbled Please add the following content to your PR description and select a checkbox: |
congbobo184
requested changes
Jul 17, 2024
Member
Author
We can take the first snapshot when the transactional producer connected. |
Member
Author
|
Another pr try to solve the same problem, close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When broker enable txn, but client don't use txn feature, we expect that the tb would't take snapshot. But it did.
Modifications
Guarantee that tb would''t take snapshot.
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: thetumbled#61