-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix] [broker] Internal reader of __change_events can not started after metadata store session rebuilt #23018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23018 +/- ##
============================================
- Coverage 73.57% 73.45% -0.13%
- Complexity 32624 33216 +592
============================================
Files 1877 1917 +40
Lines 139502 144072 +4570
Branches 15299 15743 +444
============================================
+ Hits 102638 105824 +3186
- Misses 28908 30131 +1223
- Partials 7956 8117 +161
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Can we cover the new load balancer behavior too? |
|
@heesung-sn
Sure, I will push two following PRs to do this:
|
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Show resolved
Hide resolved
68143c4 to
bf8b6a9
Compare
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Outdated
Show resolved
Hide resolved
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
Outdated
Show resolved
Hide resolved
…er metadata store session rebuilt (apache#23018) (cherry picked from commit b955c65) (cherry picked from commit 0e59678)
…er metadata store session rebuilt (apache#23018) (cherry picked from commit b955c65) (cherry picked from commit 0e59678)
…er metadata store session rebuilt (apache#23018) (cherry picked from commit b955c65) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
…er metadata store session rebuilt (apache#23018)
Motivation & Modifications
1. Fix the issue below
systemTopic & topicLevelPolicies.broker-2loads atopic-aup.broker-2loads system topic({ns}/__change_events) up.topic-awas transferred tobroker-0{ns}/__change_events) was transferred tobroker-0broker-2{ns}/__change_eventslookup the topic's ownerbroker-2respondsbroker-2due to itsOwnershipCachecontains the old value.{ns}/__change_eventscan not be created successfully, all topics under this namespace can not work.broker-2will get a wrong value, and keep getting a "Please redo the lookup" error.2. Add a test to confirm the topic will be unloaded after the metadata store session is rebuilt.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x