-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][build] Move docker-push profile to submodule #23093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23093 +/- ##
============================================
- Coverage 73.57% 73.44% -0.14%
- Complexity 32624 33524 +900
============================================
Files 1877 1919 +42
Lines 139502 144087 +4585
Branches 15299 15745 +446
============================================
+ Hits 102638 105824 +3186
- Misses 28908 30145 +1237
- Partials 7956 8118 +162
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 47d35a0)
Motivation
The profile refactoring breaks the pulsar release in the #23091.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete