Skip to content

[cleanup][broker] Remove PersistentSubscription.getStats #23095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodece merged 2 commits into from
Jul 30, 2024
Merged

[cleanup][broker] Remove PersistentSubscription.getStats #23095

nodece merged 2 commits into from
Jul 30, 2024

Conversation

@nodece
Copy link
Member

@nodece nodece commented Jul 29, 2024

Motivation

Clean up org.apache.pulsar.broker.service.persistent.PersistentSubscription#getStats method.

Modifications

  • org.apache.pulsar.broker.service.persistent.PersistentTopic#removeSubscription returns CompletableFuture<Void>
  • Remove PersistentSubscription#getStats method and call

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece
[cleanup][broker] Remove PersistentSubscription.getStats
51bef23 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece force-pushed the remove-PersistentSubscription.getStats branch from c4f38a4 to 51bef23 Compare July 29, 2024 17:19
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 29, 2024
@nodece nodece changed the title Remove PersistentSubscription.getStats [cleanup][broker] Remove PersistentSubscription.getStats Jul 29, 2024
lhotari
lhotari approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece
Fix style
1425554 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece self-assigned this Jul 30, 2024
@nodece nodece added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use ready-to-test labels Jul 30, 2024
@nodece nodece added this to the 3.4.0 milestone Jul 30, 2024
@nodece nodece merged commit 19fe2e4 into apache:master Jul 30, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@nodece @hanmz
[cleanup][broker] Remove PersistentSubscription.getStats (apache#23095)
d6b4d0a 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@crossoverJie crossoverJie crossoverJie approved these changes

Assignees

@nodece nodece

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nodece @lhotari @crossoverJie