[improve][pip] PIP-376: Make topic policies service pluggable #23248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
RobertIndie,
codelipenghui,
lhotari and
shibd
github-actions
bot
added
the
doc
Contributor
Author
|
Here is the draft implementation in my fork: BewareMyPower#35 |
eolivelli
reviewed
Sep 3, 2024
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
I generally support this proposal, we should have clearer APIs for the components we want to allow users to customize
Member
|
I support |
Contributor
codelipenghui
left a comment
codelipenghui
left a comment
There was a problem hiding this comment.
@BewareMyPower Thanks for driving the proposal
Could you please also add a section to describe what the TopicPoliciesService finally looks like?
lhotari
reviewed
Sep 4, 2024
Contributor
Author
|
Now I've refactored the proposal, as well as the demo implementation with the following changes:
@eolivelli @codelipenghui @lhotari PTAL again |
codelipenghui
approved these changes
Sep 4, 2024
lhotari
approved these changes
Sep 4, 2024
Member
lhotari
left a comment
lhotari
left a comment
There was a problem hiding this comment.
LGTM. Good work @BewareMyPower!
RobertIndie
reviewed
Sep 6, 2024
RobertIndie
approved these changes
Sep 6, 2024
Member
RobertIndie
left a comment
RobertIndie
left a comment
There was a problem hiding this comment.
LGTM. Just one minor comment: #23248 (comment)
Co-authored-by: Zike Yang <zike@apache.org>
BewareMyPower
deleted the
bewaremypower/pip-376-pluggable-topic-policies-doc
branch
michalcukierman
pushed a commit
to michalcukierman/pulsar
that referenced
this pull request
Sep 11, 2024
4 tasks
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation
docdoc-requireddoc-not-neededdoc-complete