Skip to content

Conversation

@heesung-sohn
Copy link
Contributor

@heesung-sohn heesung-sohn commented Sep 30, 2024

Motivation

This PR(#23301) introduces the ServiceUnitStateMetadataStoreTableView, which persists ownership information in metadata store. When this is used, we don't need to configure system topic in the monitor thread. Currently, the monitor thread unnecessarily tries to configure the system topic and prints red-herring error logs Failed to set compaction threshold for system topic:persistent://pulsar/system/loadbalancer-service-unit-state

Modifications

  • check if the system topic is used before calling the configureSystemTopics

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions
Copy link

@heesung-sn Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-label-missing doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 30, 2024
@heesung-sohn heesung-sohn reopened this Sep 30, 2024
@heesung-sohn heesung-sohn changed the title [imporve][broker] check system topic is used before configuring system topic (ExtensibleLoadManagerImpl only) [improve][broker] check system topic is used before configuring system topic (ExtensibleLoadManagerImpl only) Oct 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (bbc6224) to head (533bc01).
Report is 617 commits behind head on master.

Files with missing lines Patch % Lines
...dbalance/extensions/ExtensibleLoadManagerImpl.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23381      +/-   ##
============================================
+ Coverage     73.57%   74.51%   +0.93%     
- Complexity    32624    34471    +1847     
============================================
  Files          1877     1934      +57     
  Lines        139502   145139    +5637     
  Branches      15299    15870     +571     
============================================
+ Hits         102638   108149    +5511     
+ Misses        28908    28691     -217     
- Partials       7956     8299     +343     
Flag Coverage Δ
inttests 27.68% <66.66%> (+3.09%) ⬆️
systests 24.49% <0.00%> (+0.17%) ⬆️
unittests 73.87% <66.66%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...dbalance/extensions/ExtensibleLoadManagerImpl.java 78.38% <66.66%> (-1.71%) ⬇️

... and 599 files with indirect coverage changes

@heesung-sohn heesung-sohn merged commit e0b754d into apache:master Oct 1, 2024
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants