Skip to content

Conversation

@rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Oct 1, 2024

Motivation

As discussed in this email thread , updating PIP process with the improvement.
Also a recent example PIP-381 shows that this change helped the community to move faster with productive discussion and efficient voting process (VOTE approved with 2 binding vote and in less than a week). and that will help the community to get the new feature out without any unnecessary delay.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@rdhabalia rdhabalia added type/PIP doc-not-needed Your PR changes do not impact docs ready-to-test labels Oct 1, 2024
@rdhabalia rdhabalia self-assigned this Oct 1, 2024
@github-actions github-actions bot added the PIP label Oct 1, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdhabalia rdhabalia merged commit 1dad078 into apache:master Oct 2, 2024
@rdhabalia rdhabalia deleted the pip_change branch October 2, 2024 00:03
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs PIP ready-to-test type/PIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants