[fix][client] Fix Reader.hasMessageAvailable return wrong value after seeking by timestamp with startMessageIdInclusive #23502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… seeking by timestamp with startMessageIdInclusive
Contributor
Author
|
@BewareMyPower @lhotari PTAL, thanks |
lhotari
reviewed
Oct 23, 2024
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
Oct 23, 2024
Member
lhotari
left a comment
lhotari
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution @summeriiii
Contributor
Author
|
/pulsarbot run-failure-checks |
BewareMyPower
approved these changes
Oct 24, 2024
Contributor
|
The failed flaky test is #23474, let's merge this PR first |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 5, 2024
… seeking by timestamp with startMessageIdInclusive (apache#23502) (cherry picked from commit fcb3592) (cherry picked from commit b7b69dc)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Nov 6, 2024
… seeking by timestamp with startMessageIdInclusive (apache#23502) (cherry picked from commit fcb3592)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 7, 2024
… seeking by timestamp with startMessageIdInclusive (apache#23502) (cherry picked from commit fcb3592) (cherry picked from commit b7b69dc)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 7, 2024
… seeking by timestamp with startMessageIdInclusive (apache#23502) (cherry picked from commit fcb3592) (cherry picked from commit b7b69dc)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
… seeking by timestamp with startMessageIdInclusive (apache#23502)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23501
Motivation
When seek to the current time
reader.seek(System.currentTimeMillis());,reader.hasMessageAvailable()should return false cause there has no message to read, but right now it returns true.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: