[improve][ml]Set default value of managedLedgerPersistIndividualAckAsLongArray to true #23888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LongArray to true
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23888 +/- ##
============================================
+ Coverage 73.57% 74.22% +0.65%
+ Complexity 32624 32216 -408
============================================
Files 1877 1853 -24
Lines 139502 143638 +4136
Branches 15299 16317 +1018
============================================
+ Hits 102638 106621 +3983
+ Misses 28908 28639 -269
- Partials 7956 8378 +422
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…LongArray to true (apache#23888)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Regard [DISCUSS] Add an optional config to disable the feature that compresses cursor metadata, which was contributed by #9292, we get a conclusion:
branch-3.0, branch-3.3, branch-4.0: set default value of the featuremanagedLedgerPersistIndividualAckAsLongArraytofalsebranch-4.1: set the default value of the featuremanagedLedgerPersistIndividualAckAsLongArraytotrueModifications
true. This PR should not be cherry-picked into previous versions.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x