Replicator stop retrying to read when cursor is already closed #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
Contributor
Author
rdhabalia
added a commit
that referenced
this pull request
Feb 24, 2017
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
…oint) to WorkerService (apache#239)
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
…est endpoint) to WorkerService (apache#239)" (apache#241) This reverts commit 8fd1fd1870753ea8fb2576873800380ac2cea3dd.
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
…point) to WorkerService (apache#242) * Move all the components required for running worker (except rest endpoint) to WorkerService (apache#239) * start worker service
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
…ache#248) Fixes apache#239 ### Motivation As @wolfstudy pointed out here apache/pulsar-client-go#239 (comment) There is a race on callbacks of `pendingReqs` when closing the connection while the run loop is still running, which will lead to calling a callback up to 2 times: https://github.com/apache/pulsar-client-go/blob/e7f1673350f208b5063823282d14906d70d66904/pulsar/internal/connection.go#L669-L671 ### Modifications Introducing a `runLoopStoppedCh` to make sure that the run loop has already stopped when cleaning callbacks of `pendingReqs` in the `Close()`
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Replicator's ManagedCursor gets closed when replicator is deleted from the policies. However, as Removing Replicator for a topic is not performed atomically and because of that sometimes, replicator-producer tries to read from Cursor which already Closed. In that case, replicator should not retry to read the message again (because replicator is already removed and cursor is closed for that replicator) and consider
CursorAlreadyClosedExceptionas non-retriable exception, close the producer and stop the replicator.Modifications
Replicator considers
CursorAlreadyClosedExceptionas non-retriable exception so, it stops retrying further read and closes the producer.Result
PersistentReplicator will not retry read on
CursorAlreadyClosedException.