[fix][broker] Restore the behavior to dispatch batch messages according to consumer permits #24092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to consumer permits
BewareMyPower
added
type/bug
BewareMyPower
requested review from
RobertIndie,
codelipenghui,
lhotari,
poorbarcode,
rdhabalia and
shibd
poorbarcode
approved these changes
Mar 18, 2025
lhotari
approved these changes
Mar 18, 2025
Member
lhotari
left a comment
lhotari
left a comment
There was a problem hiding this comment.
Thanks for spotting this regression @BewareMyPower. I added one suggestion.
.../java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Outdated
Show resolved
Hide resolved
BewareMyPower
force-pushed
the
bewaremypower/flaky-testBatchMessage
branch
from
32019f4 to
3ca7df6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24092 +/- ##
============================================
+ Coverage 73.57% 74.18% +0.61%
+ Complexity 32624 32427 -197
============================================
Files 1877 1863 -14
Lines 139502 144312 +4810
Branches 15299 16457 +1158
============================================
+ Hits 102638 107063 +4425
+ Misses 28908 28773 -135
- Partials 7956 8476 +520
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
gaoran10
approved these changes
Mar 19, 2025
nodece
approved these changes
Mar 19, 2025
3 tasks
3 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 28, 2025
…ng to consumer permits (apache#24092) (cherry picked from commit 2f6345d) (cherry picked from commit 2fb9cb5)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2025
…ng to consumer permits (apache#24092) (cherry picked from commit 2f6345d) (cherry picked from commit 2fb9cb5)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 31, 2025
…ng to consumer permits (apache#24092) (cherry picked from commit 2f6345d) (cherry picked from commit 2fb9cb5)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…ng to consumer permits (apache#24092)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23825
Motivation
It seems that the PIP-379 breaks #7266. For example, given the following configs:
When
subscriptionSharedUseClassicPersistentImplementationis false (by default), 10 entries will be dispatched to the consumer. When it's true (the behavior before 4.0), only 1 entry will be dispatched to the consumer.Modifications
Fix the
maxEntriesInThisBatchcalculation inPersistentDispatcherMultipleConsumers. IntestBatchMessageDispatchingAccordingToPermits, wait until the entries are dispatched to consumers. Then this test would fail without this fix.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: