[fix][client] Fix inconsistent compression threshold behavior across batching modes #24102
+20
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation Unify the data size check during compression. Currently, there is inconsistency in the criteria for determining the threshold of messages with compression enabled: For instance, with compressMinMsgBodySize set to 4kb: - When batching is not enabled, compression is applied to messages that are equal to or greater than 4kb. - When batching is enabled, compression is applied to messages that are greater than 4kb. ## Modifications 1. Standardize the criteria for determining the threshold to enable compression. 2. Optimize formatting. 3. Enhance testing.
|
@liangyepianzhou Please add the following content to your PR description and select a checkbox: |
liangyepianzhou
requested review from
eolivelli,
lhotari,
poorbarcode and
thetumbled
github-actions
bot
added
doc-not-needed
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM |
lhotari
reviewed
Mar 25, 2025
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerConsumerInternalTest.java
Show resolved
Hide resolved
liangyepianzhou
changed the title
Technoboy-
approved these changes
Mar 25, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…batching modes (apache#24102) Co-authored-by: xiangying <mengxiangying@xiaohongshu.com> apache#23526 ## Motivation Fix inconsistent compression threshold behavior across batching modes. For single message sending, compression is enabled when the message size is greater than or equal to the threshold, while for batch sending, compression occurs when the size is greater than the threshold. ## Modifications 1. Standardize the criteria for determining the threshold to enable compression. 2. Optimize formatting. 3. Enhance testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23526
Motivation
Fix inconsistent compression threshold behavior across batching modes. For single message sending, compression is enabled when the message size is greater than or equal to the threshold, while for batch sending, compression occurs when the size is greater than the threshold.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: