-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][client] Pattern subscription regression when broker-side evaluation is disabled #24104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isable pattern evaluation
poorbarcode
reviewed
Mar 21, 2025
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java
Show resolved
Hide resolved
poorbarcode
approved these changes
Mar 21, 2025
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java
Show resolved
Hide resolved
poorbarcode
approved these changes
Mar 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24104 +/- ##
============================================
+ Coverage 73.57% 74.27% +0.69%
+ Complexity 32624 32484 -140
============================================
Files 1877 1864 -13
Lines 139502 144351 +4849
Branches 15299 16464 +1165
============================================
+ Hits 102638 107212 +4574
+ Misses 28908 28686 -222
- Partials 7956 8453 +497
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 27, 2025
…tion is disabled (apache#24104) (cherry picked from commit d7962a1)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 27, 2025
…tion is disabled (apache#24104) (cherry picked from commit d7962a1) (cherry picked from commit 734f79f)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 28, 2025
…tion is disabled (apache#24104) (cherry picked from commit d7962a1) (cherry picked from commit 734f79f)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 28, 2025
…tion is disabled (apache#24104) (cherry picked from commit d7962a1) (cherry picked from commit 4db81d7)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2025
…tion is disabled (apache#24104) (cherry picked from commit d7962a1) (cherry picked from commit 4db81d7)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 31, 2025
…tion is disabled (apache#24104) (cherry picked from commit d7962a1) (cherry picked from commit 4db81d7)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.11
release/3.3.6
release/4.0.4
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When EnableBrokerSideSubscriptionPatternEvaluation is set to false, the pattern subscription can't discover newly created topics.
This regression was introduced by PR #21853 and #22854, which removed pattern consumer regularity discovery topic logic:
https://github.com/apache/pulsar/pull/22854/files#diff-779a47f80b0048bab183870ed4c1ecd07ffd538006cf9358e494bee23405d924L154-L159
Modifications
watcherFuturereturns an exception.recheckPatternTaskBackoffas it is unused and does not align with the user-side configurationpatternAutoDiscoveryPeriod.consumer.getRecheckPatternTimeout().task().run(consumer.getRecheckPatternTimeout());from the unit tests, because these tests now operate under the premise of the broker actively pushing topic changes.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: